CI workflow improvements #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicoddemus
commented
Oct 20, 2022
nicoddemus
commented
- Drop 'checks' job from CI: this job is redundant now that we use pre-commit.ci and readthedocs builds docs for PRs.
- Split workflows into 'deploy' and 'build' for easier management.
This job is redundant now that we use pre-commit.ci and readthedocs builds docs for PRs.
The-Compiler
requested changes
Oct 25, 2022
| @@ -58,50 +58,3 @@ jobs: | |||
| - name: Test with tox | |||
There was a problem hiding this comment.
While you're at it, maybe change 3.11-dev to 3.11 above (released now), and also re-check if pyside6 works on it nowadays?
| - name: Linting | ||
| run: | | ||
| tox -e linting | ||
| - name: Docs |
There was a problem hiding this comment.
Do we really have a check failing the PR status from RTD, if a PR breaks the docs? Scrolling through the commit status list of this PR, I can't seem to find any?
There was a problem hiding this comment.
Good catch, I have re-synced the webhook from RTD and is now working again:
Co-authored-by: Florian Bruhin <[email protected]>
|
Seems like 3.11 is not available for mac-os yet, let's wait a few days to try this again as this is not critical. |
|
According to actions/setup-python#531 this was fixed a day later 😅 I triggered a rerun. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.