replace itertools.chain.from_iterable

pytest-dev · Feb 15, 2020 · 2ba59a1 · 2ba59a1
1 parent 2e81042
commit 2ba59a1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/doc/en/example/assertion/failure_demo.py b/doc/en/example/assertion/failure_demo.py
@@ -45,8 +45,7 @@ def test_eq_text(self):
         assert "spam" == "eggs"
 
     def test_eq_similar_text(self):
-        x = "foo\n1 bar\n"
-        assert x == "foo\n1 bar"
+        assert "foo 1 bar" == "foo 2 bar"
 
     def test_eq_multiline_text(self):
         assert "foo\nspam\nbar" == "foo\neggs\nbar"

diff --git a/src/_pytest/assertion/util.py b/src/_pytest/assertion/util.py
@@ -235,7 +235,7 @@ def _diff_text(left: str, right: str, verbose: int = 0) -> List[str]:
 
     if any(
         wcwidth(ch) <= 0
-        for ch in itertools.chain.from_iterable(x for x in left_lines + right_lines)
+        for ch in [ch for lines in left_lines + right_lines for ch in lines]
     ):
         left_lines = [repr(x) for x in left_lines]
         right_lines = [repr(x) for x in right_lines]