nodes: keep plugins which subclass Item, File working for a bit more (#…

…9279) * nodes: keep plugins which subclass Item, File working for a bit more Fix #8435. * Update src/_pytest/nodes.py Co-authored-by: Bruno Oliveira <[email protected]> Co-authored-by: Florian Bruhin <[email protected]> Co-authored-by: Bruno Oliveira <[email protected]>
pytest-dev · Nov 8, 2021 · f87df9c · f87df9c
1 parent eb6c449
commit f87df9c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/_pytest/nodes.py b/src/_pytest/nodes.py
@@ -669,9 +669,13 @@ def __init__(
         nodeid: Optional[str] = None,
         **kw,
     ) -> None:
+        # The first two arguments are intentionally passed positionally,
+        # to keep plugins who define a node type which inherits from
+        # (pytest.Item, pytest.File) working (see issue #8435).
+        # They can be made kwargs when the deprecation above is done.
         super().__init__(
-            name=name,
-            parent=parent,
+            name,
+            parent,
             config=config,
             session=session,
             nodeid=nodeid,

diff --git a/testing/test_nodes.py b/testing/test_nodes.py
@@ -71,7 +71,7 @@ def test_subclassing_both_item_and_collector_deprecated(
         ),
     ):
 
-        class SoWrong(nodes.File, nodes.Item):
+        class SoWrong(nodes.Item, nodes.File):
             def __init__(self, fspath, parent):
                 """Legacy ctor with legacy call # don't wana see"""
                 super().__init__(fspath, parent)