You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #10482 made it so that if a fixture calls skip(), the skip location is shown as the test function, not the fixture. But it excluded xunit setup fixtures from this.
I suspect this was done to make a pre-existing test pass, however I think that the same reason for fixtures applies to xunit fixtures just as well, so we shouldn't exclude it.
Would also remove a string-hack that was used to implement this exclusion...
PR #10482 made it so that if a fixture calls
skip()
, the skip location is shown as the test function, not the fixture. But it excluded xunit setup fixtures from this.I suspect this was done to make a pre-existing test pass, however I think that the same reason for fixtures applies to xunit fixtures just as well, so we shouldn't exclude it.
Would also remove a string-hack that was used to implement this exclusion...
pytest/src/_pytest/fixtures.py
Lines 1162 to 1168 in bf451d4
The text was updated successfully, but these errors were encountered: