Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force terminal width when running tests #11425

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Sep 10, 2023

Fixes #11423

@nicoddemus nicoddemus added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Sep 10, 2023
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be slightly overboard,I wonder if that may hide possible issues

@nicoddemus
Copy link
Member Author

This might be slightly overboard

You mean this being an autouse fixture, so you would prefer to only apply it to the tests which fail?

@RonnyPfannschmidt
Copy link
Member

I'm not sure where to draw the line here, it's a very "it depends" choice

Lets perhaps log down a tasks too investigate The results

@nicoddemus nicoddemus merged commit 241f2a8 into pytest-dev:main Sep 11, 2023
23 checks passed
@nicoddemus nicoddemus added backport 7.4.x and removed needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch labels Sep 11, 2023
@nicoddemus
Copy link
Member Author

Lets perhaps log down a tasks too investigate The results

Sounds good, can you do it? It would be useful to list some ideas as well.

@nicoddemus nicoddemus deleted the 11423-term-width branch September 11, 2023 12:23
nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Sep 11, 2023
nicoddemus added a commit that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants