Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept None in _XfailMarkDecorator's conditionparam and expose default value #11565

Closed
wants to merge 2 commits into from

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Oct 27, 2023

Thanks for submitting a PR, your contribution is really appreciated!

Here is a quick checklist that should be present in PRs.

  • Include documentation when adding new features.
  • [N/A] Include new tests or update existing tests when applicable.
  • Allow maintainers to push and squash when merging my commits. Please uncheck this if you prefer to squash the commits yourself.

If this change fixes an issue, please:

  • Add text like closes #XYZW to the PR description and/or commits (where XYZW is the issue number). See the github docs for more information.

Fixes comments pypa/setuptools#3979 (comment) and #10094 (comment)
Should not conflict with #11501

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.

    Write sentences in the past or present tense, examples:

    • Improved verbose diff output with sequences.
    • Terminal summary statistics now use multiple colors.

    Also make sure to end the sentence with a ..

  • Add yourself to AUTHORS in alphabetical order.

@Avasam Avasam mentioned this pull request Oct 27, 2023
2 tasks
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very torn on allowing this,
My personal preference is not to allow none there

@Avasam
Copy link
Contributor Author

Avasam commented Nov 2, 2023

If not, then the documentation for pytest.mark.xfail should probably be updated to not use None as a default value instead.

@nicoddemus
Copy link
Member

I agree we should probably just update the docs: the docs used None probably to mean "optional" (in the sense that might be given or not), not necessarily to accept None (similar to the changes in #11501). 👍

Thanks @Avasam I'm closing this then, would appreciate if you followed up with another PR just to update the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants