Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6292 - Add option to decrease terminal verbosity despite high diff verbosity. #7178

Closed
wants to merge 3 commits into from

Conversation

piotrhm
Copy link
Contributor

@piotrhm piotrhm commented May 7, 2020

This pull request implements suggested approach for issue #6292. It might also be solution to #6723.

Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @piotrhm, thanks for working on this.

From reading the issues, it seems to me that this does not cover all of the use cases. The issues and this PR want to control various aspects of verbosity independently which are currently all aggregated in the single verbosity level. So if we merge this without considering the other use cases, it might lead to a sub-optimal result.

IMO what is needed is:

  • Audit and list all aspects that are currently controlled by verbosity.
  • Gather requirements on which aspects should be possible to control independently.
  • Draft a proposal/PR for implementing this with new flags and/or ini options in a backwards compatible manner with existing verbosity.

@nicoddemus
Copy link
Member

Hi @piotrhm,

As per our policy I'm closing this for now just to clear up our queue, but as always, please feel free to reopen this if/when you get back to work on this. 😁

Thanks a lot!

Cheers

@nicoddemus nicoddemus closed this Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants