Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0.x] releasing: Always set doc_version #9590

Merged
merged 1 commit into from
Feb 3, 2022
Merged

[7.0.x] releasing: Always set doc_version #9590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions scripts/prepare-release-pr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,10 @@ def prepare_release_pr(

if prerelease:
template_name = "release.pre.rst"
doc_version = release_branch
elif is_feature_release:
template_name = "release.minor.rst"
doc_version = "" # unused in template
else:
template_name = "release.patch.rst"
doc_version = "" # unused in template

# important to use tox here because we have changed branches, so dependencies
# might have changed as well
Expand All @@ -107,7 +104,7 @@ def prepare_release_pr(
"--",
version,
template_name,
doc_version,
release_branch, # doc_version
"--skip-check-links",
]
print("Running", " ".join(cmdline))
Expand Down