Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User-Agent should be configurable #385

Closed
tobixen opened this issue Mar 5, 2024 · 1 comment
Closed

User-Agent should be configurable #385

tobixen opened this issue Mar 5, 2024 · 1 comment

Comments

@tobixen
Copy link
Member

tobixen commented Mar 5, 2024

Ref home-assistant/core#105292 (comment) - it seems like it's possible to set arbitrary headers to be sent in every request initiated through some davclient object, except User-Agent and some others. Now it's probably a good idea not to touch the Content-Type or Accept-headers, but the User-Agent should be possible to configure freely.

Also, passing {} as default parameter is dangerous, ref https://stackoverflow.com/questions/26320899/why-is-the-empty-dictionary-a-dangerous-default-value-in-python
tobixen added a commit that referenced this issue Mar 5, 2024
@tobixen
User-Agent should be possible to modify - see also #385
10db089
tobixen added a commit that referenced this issue Mar 5, 2024
@tobixen
User-Agent should be possible to modify - see also #385
9021a7d
@tobixen tobixen mentioned this issue Mar 5, 2024
Merged
tobixen added a commit that referenced this issue Mar 5, 2024
@tobixen
User-Agent should be possible to modify - see also #385
6fef46a
tobixen added a commit that referenced this issue Apr 13, 2024
@tobixen
User-Agent should be possible to modify - see also #385
76f1041
github-merge-queue bot pushed a commit that referenced this issue Apr 13, 2024
@tobixen
User-Agent should be possible to modify - see also #385
d3d56ad
@tobixen
Copy link
Member Author

tobixen commented Apr 13, 2024

fixed

@tobixen tobixen closed this as completed Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tobixen