Issue 4398: Fix constraint and pep 660 hook typo #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th_dev' parameter in the Factory.create_poetry call. Removed this parameter from the call.
I am unsure if these tests are checking the correct behvaiour as I was unable to locate any documentation or comments in the code that explain what the exactly the methods are supposed to be doing, or what the intention of EmptyContraint is so I had to take a guess based on the existing tests and implementations.
I realized that a union with an EmptyConstraint should probably return the original constraint since the EmptyConstraint adds no constraints. (Based on AnyConstraint it appears a union should be addative and not a union in the set sense) Also forgot to install precommit hooks so ran them against the file.
3 tasks
|
Fixed by #188 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry#4398
Would very much appreciate an expert reviewing the new tests to see if the behaviour checked is correct. I do not have time to parse through the code base in enough detail to be certain about what the expected behaviour should be so this is my best guess.