-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
usage on readthedocs.org #754
Comments
@cjw296 Did you run into a specific error when building your site? My |
How did you install your package? Doesn’t rtd only support pip (and maybe conda if you’re very lucky?)
… On 19 Dec 2018, at 15:20, Jace Browning ***@***.***> wrote:
@cjw296 Did you run into a specific error when building your site?
My mkdocs site built fine without telling readthedocs.org anything about poetry: https://datafiles.readthedocs.io
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I use Sphinx, and to build correctly, the package needs to be installed. |
RTD issue here: readthedocs/readthedocs.org#4912 |
Aside from documentation I don't belive this is an issue of However, documentation on how to use RTD would be great! 👍 |
Not a super elegant solution, but you can use a requirements.readthedocs.txt
Then enable |
Is there any way to install dev-dependencies by version: 2
python:
version: 3.6
install:
- method: pip
path: .
extra_requirements:
- docs |
I suspect this requires the "editable install support as an extension to PEP 517" mentioned in pypa/pip#6314 (comment). |
@finswimmer - can you explain why you've closed this? |
Hello @cjw296, sorry I could have written some words about it. I've closed this because there were nor more comments for more than a year. Furthermore it doesn't look like a poetry problem. If you disagree please explain it a bit more, why you think that is something poetry should solve. We can discuss about it of course. fin swimmer |
Poetry's direction and approach seems pretty hostile to my use cases nowadays, and closing issues just because no-one's had time to bottom them out seems counterproductive. This isn't the first time I've disagreed with your approach, and I'm sorry to see @sdispater cede so much direction and control of this project to you; Poetry had plenty of potential, but the direction you're driving it doesn't work for me. |
Are you saying that we should accept and abide by your use cases, no questions asked? The thing is that I agree with @finswimmer here: this is not an issue with Poetry but with RTD and you already pointed to an issue on the RTD repository where the discussion is more suited (readthedocs/readthedocs.org#4912). That being said, if you feel that Poetry could do something here and you are willing to implement it, I'd happily review a PR but for now I really think this is out of our hands. |
As advised here: python-poetry/poetry#754
RTD does seem to allow custom shell commands with the most recent update: https://docs.readthedocs.io/en/latest/build-customization.html I havn't tested it yet, but I assume this should allow to install dev dependencies (or in Poetry 1.2 and higher the respective dependency groups for docs) EDIT: Here is a link to a working solution using this feature: readthedocs/readthedocs.org#4912 (comment) |
Do note that this will install all optional dependencies, which is really not ideal. It effectively makes specifying extra_requirements pointless, as it will just install every dependency under I recommend doing the solution linked by @AKuederle but add |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Issue
How can I have readthedocs.org build a project that I'm developing using poetry?
Hopefully this is just a documentation issue...
The text was updated successfully, but these errors were encountered: