-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ux): improve command not found errors #10127
Conversation
Reviewer's Guide by SourceryThis pull request improves the error message when a user attempts to use a command that does not exist within a namespace. Instead of a generic command not found error, the user will now see a more specific error message that indicates the command does not exist in the given namespace, along with a list of suggested commands and a link to the documentation. Sequence diagram for improved namespace command error handlingsequenceDiagram
actor User
participant App as Poetry Application
participant IO as IO Interface
User->>App: Execute command
App->>App: Check command exists
alt Command not found but namespace exists
App->>App: Get sub-commands in namespace
App->>App: Find similar command names
App->>IO: Write error with suggestions
App->>IO: Write documentation link
IO-->>User: Display error message
else Other error
App->>App: Raise original error
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @abn - I've reviewed your changes - here's some feedback:
Overall Comments:
- There's a grammatical error in the error message: "does not exists" should be "does not exist"
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
6212c6e
to
d682590
Compare
77a8fd7
to
9dced99
Compare
9dced99
to
c7d93a3
Compare
fix(ux): improve namespace command not found error
Resolves: #10123
fix(ux): improve command not found error
Summary by Sourcery
Bug Fixes: