-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation on migrating and using different python versions (#305) #332
Conversation
* Add documentation on how to migrate from other common workflows * Add documentation that explains the approved approach to creating a virtualenv with specific python version
I think that a short blurb on what |
to give an idea: tox is configured like for poetry's repo with So when I come inside the directory, 'myvenv" is auto activated which is cool to launch some commands easily. If you do not want to use tox, you can create custom venv with pyenv with preferred python version and switch between them with |
Thanks for suggestions, i'll try to come up with an update tomorrow. By the way if any of you feel like it, i would really love some contributions, as writing an easy-to-read documentation is not my strong suit. |
I formalized it : https://github.com/jgirardet/poetry/blob/master/docs/docs/basic-usage.md |
Oh well, it seems like we have different approaches in mind. I myself just put the version @sdispater showed in #305. In his version you leave management of virtualenv to poetry, while in your you create virtualenvs manually. Both approaches are valid, but i think that only one should be in the docs to avoid confusion.
Thoughts? |
about creating virtuelenvIn every project you fork on github, the python version used by maintainer is never "included" with. You usually use your system python or what you (installed via deb or tgz file...). The maintainer only say to you : "my package works with python 3.5 and3.6 only". It's up to you to have it on your system. about testingWhere I agree with you is concerning the testing part. since the user wants to run tests with tox but can't have every supported python version, tox.ini should have the about .python-version:I think this should not be put in vcs. It's up to the user to choose how he deals with the different python version. As an example : If use use pyenv, i'll create locally a .python-version my my desired pyenv version and use If you want to use pyenv without virtualenv with multiple poetry install you still have to use a the command about multiple poetry installSince you have to update each python version, for each new poetry update, I think i'ts really cumbersome. about choosing a default way to install or to do thingsAfter reflexion, if documentation is clear : "you have this way with those benefits or counterpart and this way with this benefits an counter parts" I think both could live together. end of the flood 😉 |
Good point on upgrading poetry, that really is a "killer" in my eyes. That leaves me wondering if there is another way to manage it, as both suggested ways look sub-optimal. |
I like |
I am closing this PR as a lot has happened since then. The installer no longer requires to be installed for each python version and we will have #731 when version |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This pull request addresses #305.
Note that its something of a draft and could use some polishing. Still, it feels like its better than nothing :)