Fix Selenium test failure #2034
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swtormy
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified that the Selenium tests work when pinning the version of
seleniumto<4.27.0. In the release notes for 4.27.0 I found a mention of deprecation ofGetAttribute, which corresponds to the error message we are seeing. They deprecated a method call we do in the geojson tests, see SeleniumHQ/selenium#13334.I tried to fix it by changing that method call, but that didn't work out.
I don't have time to dive into this further, so for now just pin the Selenium version to <4.27.0.
At a glance it looks like they are grappling with something adjacent as well on the Selenium side (see SeleniumHQ/selenium#14808 and SeleniumHQ/selenium#14800) so might be best to sit tight and see in a few weeks what they came up with.