Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.ac update #96191

Closed
ghost opened this issue Aug 22, 2022 · 2 comments
Closed

configure.ac update #96191

ghost opened this issue Aug 22, 2022 · 2 comments

Comments

@ghost
Copy link

ghost commented Aug 22, 2022

The configure messages refer to bugs.python.org.

Tests / Check if generated files are up to date (pull_request)

A PR with a solitary edit to configure.ac will fail the above test.

sed -i "s#https://bugs.python.org/#https://github.com/python/cpython/issues#g" cpython/configure.ac

I would leave it to someone else to open a PR.

  • install podman or docker
  • run ./configure to generate the Makefile
  • run make regen-configure
  • done

A Member can decide whether to mention podman and docker in the 1st block comment of configure.ac .

$ ed -s cpython/configure.ac <<<'1,13p'
dnl ***************************************************
dnl * Please run autoreconf -if to test your changes! *
dnl ***************************************************
dnl
dnl Python's configure script requires autoconf 2.69 and autoconf-archive.
dnl

# Set VERSION so we only need to edit in one place (i.e., here)
m4_define(PYTHON_VERSION, 3.12)

AC_PREREQ([2.69])

AC_INIT([python],[PYTHON_VERSION],[https://bugs.python.org/])
$ 
@ghost
Copy link
Author

ghost commented Aug 23, 2022

dnl ***************************************************
dnl * Please run autoreconf -if to test your changes! *
dnl ***************************************************
dnl
dnl Python's configure script requires autoconf 2.69 and autoconf-archive.
dnl
dnl An easy way to generate files for upstream, after modifying this
dnl file, is to install podman or docker, run ./configure and then
dnl make regen-configure.
dnl

@ghost
Copy link
Author

ghost commented Aug 25, 2022

I suggest merging the linked to PR as is.

If the file is revisited for update in the future some comment modifications might be made.

this is a good example of comment style

As the minimum autoconf version is included in the code there is no need to restate this in a comment.

The autoconf-archive package may be included with an installed Program Development series but may not always be installed.

  dnl
- dnl Python's configure script requires autoconf 2.69 and autoconf-archive.
  dnl

  # Set VERSION so we only need to edit in one place (i.e., here)
  m4_define(PYTHON_VERSION, 3.12)

+ dnl Some Linux distros may require installing autoconf-archive.
  AC_PREREQ([2.69])

setup-select-w

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant