-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-102778: Add sys.last_exc, deprecate sys.last_type, sys.last_value,sys.last_traceback #102779
Conversation
iritkatriel
commented
Mar 17, 2023
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: Add sys.last_exc, deprecate sys.last_type, sys.last_value and sys.last_traceback #102778
…value, sys.last_traceback
Co-authored-by: Alex Waygood <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more docs nits
Misc/NEWS.d/next/Core and Builtins/2023-03-17-13-43-34.gh-issue-102778.ANDv8I.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Waygood <[email protected]>
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit e1cc312 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t pdb.pm() be changed to use sys.last_exc?
Yes, idlelib too. But I'm not sure whether we do that now or in 3.14 when it won't interfere with backports. |
I would do it now, but look both (in case user code sets one or the other): if sys.last_exc exists, use that, else if sys.last_(type,value,traceback) exist, use those, else fail. Then in the future we can delete the code checking for the latter. |
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 2ce2c26 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Please revert the changes to idlelib. (Why the rush before I could respond.) I dislike the awkward workaround changes, which IDLE does not need, and they cannot be backported. I would much prefer to make more extensive changes that get rid of nearly all references to the deprecated attributes and which can be backported. For instance, in test_stackviewer setup, replace Let me request again (from the previous PR that was closed) that idlelib changes be put in a separate PR that I can review and backport. |
Sorry, will revert and fix. |
If a user tries to access sys.last_type or sys.last_traceback then it won't work. Is this not an issue? |
Yes, |
…value,sys.last_traceback (python#102779)
…value,sys.last_traceback (python#102779)