Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.12] gh-108388: Split test_multiprocessing_spawn (GH-108396) #108442

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 24, 2023

Split test_multiprocessing_fork, test_multiprocessing_forkserver and
test_multiprocessing_spawn into test packages. Each package is made
of 4 sub-tests: processes, threads, manager and misc. It allows
running more tests in parallel and so reduce the total test duration.
(cherry picked from commit aa9a359)

Co-authored-by: Victor Stinner [email protected]

Split test_multiprocessing_fork, test_multiprocessing_forkserver and
test_multiprocessing_spawn into test packages. Each package is made
of 4 sub-tests: processes, threads, manager and misc. It allows
running more tests in parallel and so reduce the total test duration.
(cherry picked from commit aa9a359)

Co-authored-by: Victor Stinner <[email protected]>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot

@gpshead
Copy link
Member

gpshead commented Aug 24, 2023

this is a test suite only refactoring to pull in the long tail on parallel regrtest runs. I'll leave it up to @Yhg1s to decide if this goes in to 3.12. it'll ease maintenance.

@gpshead gpshead requested a review from Yhg1s August 24, 2023 17:37
@vstinner
Copy link
Member

this is a test suite only refactoring to pull in the long tail on parallel regrtest runs. I'll leave it up to @Yhg1s to decide if this goes in to 3.12. it'll ease maintenance.

See also: PR #108443 (split test_concurrent_futures).

@Yhg1s Yhg1s merged commit 2262190 into python:3.12 Aug 25, 2023
@miss-islington miss-islington deleted the backport-aa9a359-3.12 branch August 25, 2023 16:16
@vstinner
Copy link
Member

Nice, thanks for accepting this late test enhancement :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants