Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-108494: Document how to add a project in PCbuild/readme.txt #110077

Merged
merged 2 commits into from
Oct 2, 2023
Merged

gh-108494: Document how to add a project in PCbuild/readme.txt #110077

merged 2 commits into from
Oct 2, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 29, 2023 •
edited by bedevere-app bot
Loading

@vstinner vstinner added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Sep 29, 2023
@vstinner vstinner requested a review from a team as a code owner September 29, 2023 07:33
@bedevere-app bedevere-app bot mentioned this pull request Sep 29, 2023
Closed
@vstinner
Copy link
Member Author

cc @zooba @zware

zooba
zooba reviewed Sep 29, 2023
View reviewed changes
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this!

We should probably eventually add how to do it by hand, as I think that's how most contributors add them, but having this much here will hopefully convince someone else to write it up.

PCbuild/readme.txt Outdated Show resolved Hide resolved
PCbuild/readme.txt Show resolved Hide resolved
PCbuild/readme.txt Show resolved Hide resolved
@vstinner
Complete the doc
c0a05b4 
Add _testclinic_limited to Tools/msi/test/test_files.wxs
@vstinner
Copy link
Member Author

@zooba: I updated the PR to address your review.

@zooba
Copy link
Member

zooba commented Oct 2, 2023

LGTM 👍

@vstinner vstinner merged commit 6387b53 into python:main Oct 2, 2023
@vstinner vstinner deleted the doc_pcbuild_add_project branch October 2, 2023 16:53
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6387b5313c60c1403785b2245db33372476ac304 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 2, 2023
@vstinner @miss-islington
pythongh-108494: Document how to add a project in PCbuild/readme.txt (p…
8c86557 
…ythonGH-110077)

Add _testclinic_limited to Tools/msi/test/test_files.wxs.
(cherry picked from commit 6387b53)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 2, 2023

GH-110230 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Oct 2, 2023
@vstinner
Copy link
Member Author

vstinner commented Oct 2, 2023

More doc is always a good think, thanks for the review. I didn't know the parts that you showed me.

@bedevere-app
Copy link

bedevere-app bot commented Oct 2, 2023

GH-110232 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 2, 2023
vstinner added a commit to vstinner/cpython that referenced this pull request Oct 2, 2023
@vstinner
pythongh-108494: Document how to add a project in PCbuild/readme.txt (p…
0948cda 
…ython#110077)

(cherry picked from commit 6387b53)
vstinner added a commit to miss-islington/cpython that referenced this pull request Oct 2, 2023
@vstinner
pythongh-108494: Document how to add a project in PCbuild/readme.txt (p…
562dc61 
…ythonGH-110077)

(cherry picked from commit 6387b53)

Co-authored-by: Victor Stinner <[email protected]>
vstinner added a commit that referenced this pull request Oct 2, 2023
@vstinner
[3.11] gh-108494: Document how to add a project in PCbuild/readme.txt (…
981696e 
…#110077) (#110232)

gh-108494: Document how to add a project in PCbuild/readme.txt (#110077)

(cherry picked from commit 6387b53)
vstinner added a commit that referenced this pull request Oct 2, 2023
@miss-islington @vstinner
[3.12] gh-108494: Document how to add a project in PCbuild/readme.txt (…
74d0b60 
…GH-110077) (#110230)

gh-108494: Document how to add a project in PCbuild/readme.txt (GH-110077)

(cherry picked from commit 6387b53)

Co-authored-by: Victor Stinner <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-108494: Document how to add a project in PCbuild/readme.txt (p…
6d1fc25 
…ython#110077)

Add _testclinic_limited to Tools/msi/test/test_files.wxs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba left review comments

Assignees

@vstinner vstinner

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @zooba @miss-islington