Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-94808: Add coverage test for number check #111445

Merged
merged 5 commits into from
Oct 29, 2023
Merged

gh-94808: Add coverage test for number check #111445

merged 5 commits into from
Oct 29, 2023

Conversation

ekohilas
Copy link
Contributor

Add coverage test for number check

gh-94808: Adds a coverage test for PyNumber_Check as part of #94808

Thanks to @corona10 for helping out!

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Oct 29, 2023 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Oct 29, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@corona10 corona10 changed the title Add coverage test for number check gh-94808: Add coverage test for number check Oct 29, 2023
@bedevere-app bedevere-app bot mentioned this pull request Oct 29, 2023
Open
@corona10 corona10 self-assigned this Oct 29, 2023
corona10
corona10 reviewed Oct 29, 2023
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to extend the test to test float, and integer too?
And also for false tests for 'str' or something other types?
Looks like there is no explicit test for this API :)

corona10
corona10 reviewed Oct 29, 2023
View reviewed changes
Misc/NEWS.d/next/Tests/2023-10-29-05-41-47.gh-issue-94808.0FHZfr.rst Outdated
@@ -0,0 +1 @@
Add a C API test for the PyNumber_Check function.
Copy link
Member

@corona10 corona10 Oct 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please remove this file too :)

corona10
corona10 approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@corona10 corona10 enabled auto-merge (squash) October 29, 2023 06:41
@corona10 corona10 merged commit 842e5fc into python:main Oct 29, 2023
27 checks passed
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Oct 29, 2023
@ekohilas @iritkatriel
pythongh-94808: Add coverage test for number check (pythongh-111445)
f2fc8ee
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@ekohilas @FullteaR
pythongh-94808: Add coverage test for number check (pythongh-111445)
55e150c
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@ekohilas @aisk
pythongh-94808: Add coverage test for number check (pythongh-111445)
9a981fd
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@ekohilas @Glyphack
pythongh-94808: Add coverage test for number check (pythongh-111445)
af287e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

Assignees

@corona10 corona10

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekohilas @corona10