gh-119459: Fix HiDPI blurring of every program window that using tkinter #119902
+22
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineteendo
reviewed
Jun 4, 2024
nineteendo
reviewed
Jun 4, 2024
| # CALL BEFORE ANY TK OPERATIONS! | ||
| # URL for arguments for the ...Awareness call below. | ||
| # https://msdn.microsoft.com/en-us/library/windows/desktop/dn280512(v=vs.85).aspx | ||
| if sys.platform == 'win32': |
There was a problem hiding this comment.
In my humble opinion, can you guarantee that this code will not be called repeatedly? Maybe it only needs to be called once?
There was a problem hiding this comment.
Add a print statement to your code and just try the code below:
from tkinter import messagebox
messagebox.showinfo("info", "test")
messagebox.showinfo("info", "test")Then you'll find that it runs twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer #119459 , we believe this is a tk/tkinter bug that should be fixed in tkinter. In this PR, I added the fix code to
tkinter/__init__.py, which fixes the window blurring problem that every program that uses tkinter has. Since I had already committed fix for turtledemo and terryjreedy fix IDLE earlier, I removed them here. Also #119175 was backported to 3.12 3.13 and I think this PR should be as well.↓Fix
