Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-118507: Amend news entry #120817

Merged
merged 2 commits into from
Jul 4, 2024
Merged

gh-118507: Amend news entry #120817

merged 2 commits into from
Jul 4, 2024

Conversation

nineteendo
Copy link
Contributor

@nineteendo nineteendo commented Jun 21, 2024

Adds extra information only present in the backport to the 3.12 branch.

@bedevere-app bedevere-app bot added the docs Documentation in the Doc dir label Jun 21, 2024
@nineteendo
Copy link
Contributor Author

cc @zooba

@zooba
Copy link
Member

zooba commented Jul 4, 2024

I'm unclear. This PR is against main, which means we'll be announcing that pipes were fixed in 3.14 - why do you say it is only in 3.12?

Which branches need this change?

@nineteendo
Copy link
Contributor Author

That's correct, pipes were fixed in 3.13 and 3.14, but only the speedup to os.path.isjunction() and os.path.lexists() was mentioned. I only mentioned this fix in the backport to 3.12.

@zooba zooba added the needs backport to 3.13 bugs and security fixes label Jul 4, 2024
@zooba zooba merged commit db17291 into python:main Jul 4, 2024
26 checks passed
@miss-islington-app
Copy link

Thanks @nineteendo for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @nineteendo and @zooba, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker db1729143de0775c99e0453cb0fc01a799f289a0 3.13

@nineteendo nineteendo deleted the amend-news-entry branch July 4, 2024 14:58
@bedevere-app
Copy link

bedevere-app bot commented Jul 4, 2024

GH-121365 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 4, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants