-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-126433: Update hacl-star #126791
gh-126433: Update hacl-star #126791
Conversation
cc @msprotz |
Run Modules/_hacl/refresh.sh and update SBOM. Retrieve the change: "Lib_Memzero0.c: Fix compiler warning on 32-bit Windows".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from an SBOM POV, thanks!
@sobolevn: This change should fix the last compiler warning on 32-bit Windows:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't ever touched hacl, but the warning is gone 🎉
https://github.com/python/cpython/actions/runs/11822087838/job/32938420386?pr=126791 to update the SBOM please |
👍 |
I don't understand why |
@gpshead This likely also needs a 3.12 backport right? |
Sorry, @vstinner and @gpshead, I could not cleanly backport this to
|
There is no |
Run Modules/_hacl/refresh.sh and update SBOM.
Retrieve the change: "Lib_Memzero0.c: Fix compiler warning on 32-bit Windows".