bpo-39010: Improve test shutdown #22066
Conversation
Simply closing the event loop isn't enough to avoid warnings. If we don't also shut down the event loop's default executor, it sometimes logs a "dangling thread" warning. Follow-up to pythonGH-22017
1st1
added
needs backport to 3.8
needs backport to 3.9
|
@1st1: Please replace |
|
Thanks, Ben! |
|
Sorry, @bdarnell and @1st1, I could not cleanly backport this to |
|
Sorry @bdarnell and @1st1, I had trouble checking out the |
|
Hm, the automatic backport has failed. Ben, could you please manually backport and open PRs against 3.8 and 3.9? |
|
The backports failed because the backports of #22017 (#22035 for 3.8, #22034 for 3.9) haven't merged yet. I see an automerge label on those PRs; should i wait for them or make a new manual backport that combines #22017 and this one? (or if they get merged, can the auto-backports of this one be retried?) |
1st1
added
needs backport to 3.8
needs backport to 3.9
Simply closing the event loop isn't enough to avoid warnings. If we don't also shut down the event loop's default executor, it sometimes logs a "dangling thread" warning. Follow-up to pythonGH-22017 (cherry picked from commit be435ae) Co-authored-by: Ben Darnell <[email protected]>
|
GH-22082 is a backport of this pull request to the 3.9 branch. |
Simply closing the event loop isn't enough to avoid warnings. If we don't also shut down the event loop's default executor, it sometimes logs a "dangling thread" warning. Follow-up to pythonGH-22017 (cherry picked from commit be435ae) Co-authored-by: Ben Darnell <[email protected]>
|
GH-22083 is a backport of this pull request to the 3.8 branch. |
Oh, it's weird that automerge did nothing. Anyways, I merged them and triggered backports again. Thanks, Ben. |
Simply closing the event loop isn't enough to avoid warnings. If we don't also shut down the event loop's default executor, it sometimes logs a "dangling thread" warning. Follow-up to GH-22017 (cherry picked from commit be435ae) Co-authored-by: Ben Darnell <[email protected]> Co-authored-by: Ben Darnell <[email protected]>
Simply closing the event loop isn't enough to avoid warnings. If we don't also shut down the event loop's default executor, it sometimes logs a "dangling thread" warning. Follow-up to GH-22017 (cherry picked from commit be435ae) Co-authored-by: Ben Darnell <[email protected]> Co-authored-by: Ben Darnell <[email protected]>
…lots1 * origin/master: (63 commits) bpo-41627: Distinguish 32 and 64-bit user site packages on Windows (pythonGH-22098) bpo-38585: Remove references to defusedexpat (pythonGH-22095) bpo-41721: Add xlc options (pythonGH-22096) bpo-40486: Specify what happens if directory content change diring iteration (pythonGH-22025) bpo-41638: Improve ProgrammingError message for absent parameter. (pythonGH-21999) bpo-41713: _signal doesn't use multi-phase init (pythonGH-22087) bpo-41700: Skip test if the locale is not supported (pythonGH-22081) [doc] Update documentation on logging optimization. (pythonGH-22075) Fix 'gather' rules in the python parser generator (pythonGH-22021) bpo-41697: Correctly handle KeywordOrStarred when parsing arguments in the parser (pythonGH-22077) [doc] Fix a typo in the graphlib docs (python#22030) bpo-1635741: Port _signal module to multi-phase init (PEP 489) (pythonGH-22049) bpo-39883: Use BSD0 license for code in docs (pythonGH-17635) bpo-39010: Improve test shutdown (python#22066) bpo-41696: Fix handling of debug mode in asyncio.run (python#22069) bpo-41690: Use a loop to collect args in the parser instead of recursion (pythonGH-22053) closes bpo-41689: Preserve text signature from tp_doc in C heap type creation. (pythonGH-22058) Fix invalid escape sequences in the peg_highlight Sphinx extension (pythonGH-22047) bpo-41675: Modernize siginterrupt calls (pythonGH-22028) bpo-41685: Don't pin setuptools version anymore in Doc/Makefile (pythonGH-22062) ...
Simply closing the event loop isn't enough to avoid warnings. If we don't also shut down the event loop's default executor, it sometimes logs a "dangling thread" warning. Follow-up to pythonGH-22017
Simply closing the event loop isn't enough to avoid warnings. If we
don't also shut down the event loop's default executor, it sometimes
logs a "dangling thread" warning.
Follow-up to GH-22017
Since GH-22017 is being backported to the 3.8 and 3.9 branches, this one should be too.
https://bugs.python.org/issue39010