Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-94808: Add coverage for boolobject.c:bool_new #94859

Merged
merged 2 commits into from
Jul 14, 2022
Merged

gh-94808: Add coverage for boolobject.c:bool_new #94859

merged 2 commits into from
Jul 14, 2022

Conversation

mdboom
Copy link
Contributor

@mdboom mdboom commented Jul 14, 2022 •
edited by miss-islington
Loading

bool_new had no coverage.

Automerge-Triggered-By: GH:brandtbucher

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jul 14, 2022
@mdboom mdboom mentioned this pull request Jul 14, 2022
Open
brandtbucher
brandtbucher requested changes Jul 14, 2022
View reviewed changes
Lib/test/test_bool.py Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@mdboom @brandtbucher
Update Lib/test/test_bool.py
7d4c3a8 
Co-authored-by: Brandt Bucher <[email protected]>
@mdboom
Copy link
Contributor Author

mdboom commented Jul 14, 2022

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@brandtbucher: please review the changes made to this pull request.

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit df4d53a into python:main Jul 14, 2022
@brandtbucher brandtbucher added the needs backport to 3.11 only security fixes label Jul 15, 2022
@miss-islington
Copy link
Contributor

Thanks @mdboom for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 15, 2022
@mdboom @miss-islington
pythongh-94808: Add coverage for boolobject.c:bool_new (pythonGH-94859)
d5ebce6 
`bool_new` had no coverage.

Automerge-Triggered-By: GH:brandtbucher
(cherry picked from commit df4d53a)

Co-authored-by: Michael Droettboom <[email protected]>
@bedevere-bot
Copy link

GH-94883 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 15, 2022
brandtbucher pushed a commit that referenced this pull request Jul 15, 2022
@miss-islington @mdboom
gh-94808: Add coverage for boolobject.c:bool_new (GH-94859) (GH-94883)
8dc4de3 
`bool_new` had no coverage.

Automerge-Triggered-By: GH:brandtbucher
(cherry picked from commit df4d53a)

Co-authored-by: Michael Droettboom <[email protected]>

Co-authored-by: Michael Droettboom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mdboom @bedevere-bot @miss-islington @brandtbucher @kumaraditya303