Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-82874: Convert remaining importlib format uses to f-str. #98005

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented Oct 7, 2022

Converts the remaining importlib str.format() uses to f-strings.

@gpshead gpshead added stdlib Python modules in the Lib dir topic-importlib labels Oct 7, 2022
@gpshead gpshead requested a review from ericvsmith October 7, 2022 00:22
@gpshead gpshead changed the title Convert remaining importlib format uses to f-str. gh-82874: Convert remaining importlib format uses to f-str. Oct 7, 2022
@gpshead gpshead marked this pull request as ready for review October 7, 2022 00:41
Lib/importlib/__init__.py Outdated Show resolved Hide resolved
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one error, looks okay to me.

Lib/importlib/__init__.py Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@gpshead gpshead merged commit 27369ef into python:main Oct 7, 2022
@gpshead gpshead deleted the more-importlib-f-yes branch October 7, 2022 01:27
carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
* main:
  pythongh-86298: Ensure that __loader__ and __spec__.loader agree in warnings.warn_explicit() (pythonGH-97803)
  pythongh-82874: Convert remaining importlib format uses to f-str. (python#98005)
  Docs: Fix backtick errors found by sphinx-lint (python#97998)
  pythongh-97850: Remove deprecated functions from `importlib.utils` (python#97898)
  Remove extra spaces in custom openSSL documentation. (python#93568)
  pythonGH-90985: Revert  "Deprecate passing a message into cancel()" (python#97999)
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@jaraco
Copy link
Member

jaraco commented Dec 29, 2022

I cherry-picked this to python/importlib_resources@222aaed5.

jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stdlib Python modules in the Lib dir topic-importlib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants