Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-94808: add tests covering PyFunction_{Get,Set}Closure #99429

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Nov 13, 2022

It was like this:
Снимок экрана 2022-11-13 в 13 00 40

Now all branches are covered.

Comment on lines 6017 to 6018
Py_INCREF(closure);
return closure;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Py_INCREF(closure);
return closure;
return Py_NewRef(closure);

Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has merge conflicts now.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@encukou
Copy link
Member

encukou commented Mar 19, 2024

After a year, I took the liberty of updating to the current main branch, and fixed two nitpicks.

@gvanrossum
Copy link
Member

Sorry about that. Go ahead and merge!

@sobolevn
Copy link
Member Author

@encukou thanks a lot for your help! I forgot about this PR a long time ago :)

@encukou encukou merged commit 8182319 into python:main Mar 20, 2024
37 of 38 checks passed
@encukou
Copy link
Member

encukou commented Mar 20, 2024

No problem, happy to help :)

Usually we backport test changes to reduce future conflicts, but since this already causes conflicts in 3.12, I'll skip the backport here.

vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants