-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-94808: add tests covering PyFunction_{Get,Set}Closure
#99429
Conversation
Modules/_testcapimodule.c
Outdated
Py_INCREF(closure); | ||
return closure; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Py_INCREF(closure); | |
return closure; | |
return Py_NewRef(closure); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has merge conflicts now.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
After a year, I took the liberty of updating to the current main branch, and fixed two nitpicks. |
Sorry about that. Go ahead and merge! |
@encukou thanks a lot for your help! I forgot about this PR a long time ago :) |
No problem, happy to help :) Usually we backport test changes to reduce future conflicts, but since this already causes conflicts in 3.12, I'll skip the backport here. |
It was like this:
Now all branches are covered.