-
-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the "Status of the Python branches" table with a csv. #884
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The csv table looks much cleaner this way.
Could you convert the EOL table as well? https://devguide.python.org/devcycle/#end-of-life-branches |
If we start adding more csv files, I wonder if it would make sense to add them in a new
|
Relevant discussion about the two tables (cc @hugovk, @encukou): endoflife-date/endoflife.date#711 |
I updated the PR to include the end-of-life table, and moved both the |
Does Another option would be to combine the CSVs, and use a very simple extension in A |
I can give that a try. I set those widths manually in order to keep each row in a single line (see e.g. the screenshots in the first message).
I'm trying to gather some feedback from the endoflife folks and pydotorg in order to figure out their needs. If it turns out that a single table is better, I can combine them.
What extension? I also don't like too much the rst markup in the csv, especially the |
Hmm, locally the tables look fine after removing the |
For reference, this is how they look in FF on Windows on the preview.
You could use Sphinx CSV Filter, both to include/exclude specific columns (e.g. with/without markup), and also to only include specific rows (e.g. that are marked EOL or not). That would avoid having to write a custom directive. |
I updated the PR after the Devguide reorganization, reintroduced the I'm not sure if it's worth unifying the two CSVs and/or tables, since that adds an extra dependency and complexity. |
You could just put them in the same table, since there's already a |
Co-authored-by: Hugo van Kemenade <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be useful to have machine-readable data, for example to automate https://python-release-cycle.glitch.me/
JSON would be preferred but CSV should be fine too.
(https://endoflife.date/api/python.json doesn't do prereleases.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple updates to the release dates
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
As discussed in the docs meeting, I now merged this. There are more changes we are considering, e.g. merging the two table or creating a JSON file that is then used to create these CSVs, but those will be handled in separate PRs. |
FWIW, I think the source should be a human-writable format, and we should generate a JSON for the machines to consume (like https://peps.python.org/api/peps.json). And we should tell people to expect the source format to change whenever we feel like it. |
Thanks! Let's continue on python/docs-community#67. |
This PR fixes #883.
I kept the Sphinx markup in the csv, or otherwise it would have been lost. The markup should be easy enough to remove while parsing, and it only affects PEPs and dates. I checked if there was a way to include a separate column without markup and then ignore it in the table, but there's no such option.
While I was at it, I also fixed the column widths. Here's a comparison of the result (csv table on top, old one below):