Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
hugovk authored Aug 30, 2024
1 parent d5b537e commit e80125a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions docs/monthly-meeting/2024-08.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Please take a second to read through it!
- [Manuel] Moving the docs to Read the Docs
- Several reasons: be more open (let everyone see if the builds failed, how the builds work); faster builds;
- A test is already working for pull requests. Only PRs that touch documentation are built.
- Test: https://cpython-previews.readthedocs.io/en/main/
- Test: <https://cpython-previews.readthedocs.io/en/main/>
- [python/docs-community#5](https://github.com/python/docs-community/issues/5)
- In the last 1-2 months, we've been working on the language and version selector. In the current process this is added at build time from a JSON file, RTD does that at serve time with Javascript so even old versions of the docs link to current versions.
- We've been working to not losing what we already have but also not get rid of RTD features.
Expand All @@ -42,8 +42,8 @@ Please take a second to read through it!
- [Trey] So there won't be a change on day one.
- [Carol] For the PR previews, is there an option to link to the most changed file in the PR? [Manuel] We're working on it, don't know the details. The idea is to perform a diff and determine what changed, and link to it directly.
- Issue: [readthedocs/readthedocs.org#11319](https://github.com/readthedocs/readthedocs.org/issues/11319)
- Design doc:[readthedocs/readthedocs.org#11507](https://github.com/readthedocs/readthedocs.org/pull/11507)
- [Carol] That's way further ahead than I thought.Thank you!
- Design doc: [readthedocs/readthedocs.org#11507](https://github.com/readthedocs/readthedocs.org/pull/11507)
- [Carol] That's way further ahead than I thought. Thank you!

## Discussion

Expand Down

0 comments on commit e80125a

Please sign in to comment.