Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs/monthly-meeting/2023-12.md #96

Merged
merged 7 commits into from
Jan 2, 2024
Merged

Update docs/monthly-meeting/2023-12.md #96

merged 7 commits into from
Jan 2, 2024

Conversation

Unique-Usman
Copy link
Contributor

@Unique-Usman Unique-Usman commented Dec 31, 2023

@egeakman
Copy link
Contributor

Hi Usman, thanks for the PR! Quick note: We mostly don't include the empty sections in the meeting notes.

@Unique-Usman
Copy link
Contributor Author

@egeakman thanks, I made necessary changes.

docs/monthly-meeting/2023-12.md Outdated Show resolved Hide resolved
docs/monthly-meeting/2023-12.md Outdated Show resolved Hide resolved
docs/monthly-meeting/2023-12.md Outdated Show resolved Hide resolved
Copy link
Contributor

@egeakman egeakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Used - and same indent size (2 spaces) throughout the document for consistency
  • JDLH -> Jim

docs/monthly-meeting/2023-12.md Outdated Show resolved Hide resolved
docs/monthly-meeting/2023-12.md Outdated Show resolved Hide resolved
docs/monthly-meeting/2023-12.md Outdated Show resolved Hide resolved
docs/monthly-meeting/2023-12.md Outdated Show resolved Hide resolved
docs/monthly-meeting/2023-12.md Outdated Show resolved Hide resolved
docs/monthly-meeting/2023-12.md Outdated Show resolved Hide resolved
docs/monthly-meeting/2023-12.md Outdated Show resolved Hide resolved
docs/monthly-meeting/2023-12.md Outdated Show resolved Hide resolved
@Unique-Usman
Copy link
Contributor Author

  • Used - and same indent size (2 spaces) throughout the document for consistency
  • JDLH -> Jim

Thanks, I will take note of this next time.


[Petr] ... or `list[tuple[KeyType, int]]`?

- this has been discussed. There was opposition to adding the types to the stdlib code itself.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a source or a link to the discussion? It'd be nice if we could add it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know where it is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find it on Discourse. I guess it was too long ago, and might need new discussion -- the situation has changed in the mean time :)
Let me know if you want to work on a proposal, I can dig through mailing list archives from the 2010's for links to past discussions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I will like to @encukou. Thanks.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk hugovk merged commit 1057021 into python:main Jan 2, 2024
4 checks passed
@Unique-Usman Unique-Usman deleted the usman branch January 2, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants