-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP/RFC] Handle src-based distributions with egg-info installs - [opened] #239
Comments
In GitLab by @jaraco on Mar 25, 2020, 16:25 Commented on importlib_metadata/init.py line 270 Rather than undoing the abstraction here, I'd prefer if the handling of reading files for each type (distinfo, egginfo, egginfo legacy) were separate functions, such that this line of code and the subsequent return are unchanged. |
In GitLab by @jaraco on Mar 25, 2020, 16:25 Commented on importlib_metadata/init.py line 281 This code could be its own method, something like |
In GitLab by @jaraco on Mar 25, 2020, 16:25 Commented on importlib_metadata/init.py line 521 Can you clarify/document what |
In GitLab by @jaraco on Mar 25, 2020, 16:25 Commented on importlib_metadata/init.py line 290 I'd like to see the Also, if _path is absolute, I believe this logic will traverse all the way to |
In GitLab by @jaraco on Mar 25, 2020, 16:25 Commented on importlib_metadata/init.py line 288 I've always been uneasy about the egginfo support here. In particular, because |
In GitLab by @jaraco on Mar 25, 2020, 16:30 Thanks @blueyed for the exploration and code. As you can see, the coverage tests are failing. The project probably should have tests for the reported issues. I suggest keeping #112 and #115 separate for now and focusing on #112 here. Would you consider adding a test that captures #112, preferably based prior to these changes so it demonstrates the failed expectation? Let me know if you could use help on that. This project unfortunately can't use pytest, so the test suite is a little convoluted around fixtures, but I believe there are sufficient use-cases that it shouldn't be too difficult to re-purpose some of that behavior to test a source-layout package. |
I'm unsure if this issue was address or remains pending. The merge request got converted to an issue during the Github migration. Please feel free to re-engage the issue if the concern remains. |
I think this is still an issue: abravalheri/validate-pyproject#52 Package versions: Cross-checked with importlib_metadata 4.11.4, different but still not the same as the dist-info file list. |
I've run into a similar issue and tried to document it (and some potential solutions) here: #115 (comment) |
Replace tests of legacy API with comparable tests of traversable API.
In GitLab by @blueyed on Mar 17, 2020, 12:34
Merges fix-locate-non-wheel-editable -> master
Ref: https://gitlab.com/python-devs/importlib_metadata/-/issues/112
Ref: https://gitlab.com/python-devs/importlib_metadata/-/issues/115
The text was updated successfully, but these errors were encountered: