Pin types-setuptools to <67.4.0.2
#14788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mypyc build is failing on `master` due to the latest release of `types-setuptools`: see, e.g. https://github.com/python/mypy/actions/runs/4275505309/jobs/7442902732. python#14787 fixes the _build_ but there's still a bunch of mypyc tests failing on that PR. I haven't got time to debug them right now (and I'm not a mypyc expert, anyway!), so this is a stopgap PR to pin `types-setuptools` so that we avoid the latest release.
AlexWaygood
commented
Feb 26, 2023
AlexWaygood
changed the title
types-setuptools to <67.4.0.3types-setuptools to <67.4.0.2
JelleZijlstra
approved these changes
Feb 26, 2023
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AlexWaygood
added a commit
to AlexWaygood/mypy
that referenced
this pull request
Feb 26, 2023
This reverts commit 800e8ff.
hauntsaninja
pushed a commit
that referenced
this pull request
Feb 28, 2023
- The latest release of `types-setuptools` started causing type-check errors (and, therefore, mypyc build errors) on the `master` branch: see, e.g. https://github.com/python/mypy/actions/runs/4275505309/jobs/7442902732. - #14781 addressed some of the new errors, but didn't quite fix the build. - #14788 then pinned the `types-setuptools` dependency as a temporary stopgap measure. - This PR now attempts to unpin `types-setuptools` and fix the build errors in a more principled way.
AlexWaygood
added a commit
to AlexWaygood/mypy
that referenced
this pull request
Mar 2, 2023
- The latest release of `types-setuptools` started causing type-check errors (and, therefore, mypyc build errors) on the `master` branch: see, e.g. https://github.com/python/mypy/actions/runs/4275505309/jobs/7442902732. - python#14781 addressed some of the new errors, but didn't quite fix the build. - python#14788 then pinned the `types-setuptools` dependency as a temporary stopgap measure. - This PR now attempts to unpin `types-setuptools` and fix the build errors in a more principled way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mypyc build is failing on
masterdue to the latest release oftypes-setuptools: see, e.g. https://github.com/python/mypy/actions/runs/4275505309/jobs/7442902732.#14787 fixes the mypyc build, but there's still a bunch of mypyc tests failing on that PR. I haven't got time to debug them right now (and I'm also not particularly knowledgeable about mypyc!), so this is a stopgap PR to pin
types-setuptoolsso that we avoid the latest release.