Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct type annotations on two fields in _Arguments that are optional but are not marked as such #16897

Merged
merged 3 commits into from
Feb 11, 2024
Merged

Correct type annotations on two fields in _Arguments that are optional but are not marked as such #16897

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f22869d
Correct type annotations on two fields in _Arguments that are optiona…
sam-xif Feb 9, 2024
6f59503
Change if condition to equivalent that resolves type checking error
sam-xif Feb 9, 2024
be346f4
Restore options.custom_typeshed_dir if condition and change argument …
sam-xif Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mypy/stubtest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1878,8 +1878,8 @@ class _Arguments:
allowlist: list[str]
generate_allowlist: bool
ignore_unused_allowlist: bool
mypy_config_file: str
custom_typeshed_dir: str
mypy_config_file: str | None
custom_typeshed_dir: str | None
check_typeshed: bool
version: str

Expand Down Expand Up @@ -1922,7 +1922,7 @@ def test_stubs(args: _Arguments, use_builtins_fixtures: bool = False) -> int:
options.incremental = False
options.custom_typeshed_dir = args.custom_typeshed_dir
if options.custom_typeshed_dir:
options.abs_custom_typeshed_dir = os.path.abspath(args.custom_typeshed_dir)
options.abs_custom_typeshed_dir = os.path.abspath(options.custom_typeshed_dir)
options.config_file = args.mypy_config_file
options.use_builtins_fixtures = use_builtins_fixtures

Expand Down
Loading