Fix RawExpressionType.accept crash with --cache-fine-grained
#17588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 1072c78 (python#17148) converted all quoted types into RawExpressionType, which raised an AssertionError when accepting a TypeTriggersVisitor. Fixes python#17587. Signed-off-by: Anders Kaseorg <[email protected]>
This was referenced Jul 26, 2024
|
This looks like it could work, but one of the mypy-primer runs timed out after 6 hours. Re-running it to see if it's a fluke or this PR is introducing/exposing a bug that makes mypy hang on some code. |
|
Might be related to this mypy_primer misconfiguration: |
|
Thanks, let's see if that helps. |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
pushed a commit
that referenced
this pull request
Jul 27, 2024
) Commit 1072c78 (#17148) converted all quoted types into `RawExpressionType`, which raised an `AssertionError` when `accept`ing a `TypeTriggersVisitor`. - Fixes #17574. - Fixes #17587. Signed-off-by: Anders Kaseorg <[email protected]>
This was referenced Jul 30, 2024
ilevkivskyi
added a commit
that referenced
this pull request
Aug 4, 2024
mr-c
pushed a commit
to mr-c/mypy
that referenced
this pull request
Aug 14, 2024
md384
pushed a commit
to md384/mypy
that referenced
this pull request
Aug 14, 2024
…ed`" (python#17637) Reverts python#17588 (cherry picked from commit 41dcf1a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1072c78 (#17148) converted all quoted types into
RawExpressionType, which raised anAssertionErrorwhenaccepting aTypeTriggersVisitor.