Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to functools.partial of types #17898

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Conversation

hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented Oct 8, 2024

Fixes #17556 , fixes #17659

This comment has been minimized.

@hauntsaninja
Copy link
Collaborator Author

hauntsaninja commented Oct 8, 2024

Actually I have a better fix, pushing

@hauntsaninja hauntsaninja changed the title Handle partial of abstract types better Improvements to functools.partial of types Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Looks good to me.

@JukkaL JukkaL merged commit 621c7aa into python:master Oct 9, 2024
19 checks passed
JukkaL pushed a commit that referenced this pull request Oct 9, 2024
@hauntsaninja hauntsaninja deleted the abstract branch October 9, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants