Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config #170

Merged
merged 7 commits into from
Feb 9, 2024
Merged

Update config #170

merged 7 commits into from
Feb 9, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Feb 2, 2024

  • Add Dependabot to keep GitHub Actions up-to-date
  • Update pre-commit, add more handy checks, remove some that don't apply
  • Move isort config to pyproject.toml and specify Black profile for compatibility
  • Add link to PR of RTD docs preview

.github/dependabot.yml Show resolved Hide resolved
Comment on lines +7 to +10
groups:
actions:
patterns:
- "*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for the grouping? Sometimes deps are related and must be updated together, but other times one update is problematic and it will block the others.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly to reduce the total number of PRs to reduce "alert fatigue". I and many others get lots of PR/issue notifications, and these multiply on Dependabot days.

Other projects I maintain use grouped updates, and very occasionally one update may be problematic, but like you say, it goes both ways and sometimes they need grouping.

The vast majority of the time, grouped updates are fine.

Multiple PRs use up more CI time, and are also more cumbersome: after merging one, often it needs to rebase all the others, using more CI time, and needing to wait before merge.

@hugovk hugovk merged commit 6e9bcaa into python:main Feb 9, 2024
11 checks passed
@hugovk hugovk deleted the update-config branch February 9, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants