-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add animations to the sidebar and other small places #210
base: main
Are you sure you want to change the base?
Conversation
@hugovk Friendly ping request for review, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
It seems that this includes 3 changes:
- The smooth scrolling -- this looks ok to me.
- The sidebar animation -- from the video it looks like it has some issues, with the gray button lagging behind the rest when it's expanded. If this is fixed it might be ok to add it.
- A fade-in animation on the page -- I haven't seen this in action, but it seems somewhat unnecessary.
Thanks for the reminder, there is now a bug where the sidebar button is seen as part of the sidebar, causing it to be displayed at the end (lag) during the expanded animation. It should be pinned (split) out. I'll fix it tomorrow :) |
@ezio-melotti I've done the fix, and I've updated the preview video above to show the effect of the changes made by this PR🎉 |
I hope this theme isn't too stiff, let's make it more visually appealing :)
Added smooth scrolling for clicking sidebar links and animations for showing/hiding the sidebar
Color transition for sidebar buttons
It shouldn't affect normal usage, but it will make it more user-friendly👀
bandicam.2024-12-27.20-06-40-739.mp4
The video has been compressed, so the animation might not look very smooth.