Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add animations to the sidebar and other small places #210

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Wulian233
Copy link

@Wulian233 Wulian233 commented Dec 20, 2024

I hope this theme isn't too stiff, let's make it more visually appealing :)

Added smooth scrolling for clicking sidebar links and animations for showing/hiding the sidebar
Color transition for sidebar buttons

It shouldn't affect normal usage, but it will make it more user-friendly👀

bandicam.2024-12-27.20-06-40-739.mp4

The video has been compressed, so the animation might not look very smooth.

@Wulian233 Wulian233 marked this pull request as draft December 20, 2024 23:23
@Wulian233 Wulian233 changed the title Improve sidebar responsiveness and resizability Add animations to the sidebar and other small places Dec 21, 2024
@Wulian233 Wulian233 marked this pull request as ready for review December 21, 2024 03:00
@Wulian233
Copy link
Author

@hugovk Friendly ping request for review, thank you!

Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
It seems that this includes 3 changes:

  • The smooth scrolling -- this looks ok to me.
  • The sidebar animation -- from the video it looks like it has some issues, with the gray button lagging behind the rest when it's expanded. If this is fixed it might be ok to add it.
  • A fade-in animation on the page -- I haven't seen this in action, but it seems somewhat unnecessary.

@Wulian233
Copy link
Author

  • The sidebar animation -- from the video it looks like it has some issues, with the gray button lagging behind the rest when it's expanded. If this is fixed it might be ok to add it.

Thanks for the reminder, there is now a bug where the sidebar button is seen as part of the sidebar, causing it to be displayed at the end (lag) during the expanded animation. It should be pinned (split) out. I'll fix it tomorrow :)

@Wulian233
Copy link
Author

@ezio-melotti I've done the fix, and I've updated the preview video above to show the effect of the changes made by this PR🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants