Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py313: mark Linux-only decimal allowlist entries as unfixable for now #12061

Merged
merged 3 commits into from
May 30, 2024

Conversation

aminalaee
Copy link
Contributor

@aminalaee aminalaee commented May 30, 2024

Just to test with the pipeline

@aminalaee aminalaee force-pushed the decimal-python3.13 branch from 68b050f to a72a2ba Compare May 30, 2024 10:54

This comment has been minimized.

@aminalaee aminalaee force-pushed the decimal-python3.13 branch from 1fb52b8 to 5c1a69f Compare May 30, 2024 11:07
@aminalaee aminalaee force-pushed the decimal-python3.13 branch from 369ade3 to 124f709 Compare May 30, 2024 11:10
@AlexWaygood
Copy link
Member

AlexWaygood commented May 30, 2024

I think the parameter names changing only on Linux indicates that the setup-python build for Ubuntu is falling back to the pure-Python implementation of the decimal module instead of using the C implementation. This might be because the setup-python maintainers haven't (yet?) adjusted to the build changes CPython made in python/cpython#115119. In any event, I think this is probably something we shouldn't change in our stubs, as it's either a bug in CPython or setup-python, and it's not a change that people installing Python from python.org are likely to see.

@AlexWaygood
Copy link
Member

I suggest that instead of trying to "fix" the Linux-only allowlist entries here, we move them to a separate section of the allowlist with a comment explaining why we shouldn't try to fix them at this point in time.

This comment has been minimized.

@aminalaee
Copy link
Contributor Author

Yeah I think that makes sense, I initially started this PR to double-check what I'm seeing is right. I didn't want to start another discussion in the CPython repo (yet) 😅

@AlexWaygood
Copy link
Member

AlexWaygood commented May 30, 2024

It definitely seems like the setup-python Ubuntu build doesn't have the _decimal C extension installed for CPython 3.13.0b1. I'm not sure whether that's also going to be the case for 3.13.0b2 without changes at setup-python, or whether CPython has since made changes that mean that 3.13.0b2 will be okay.

@erlend-aasland, would you be able to clarify that at all? python/cpython#115119 is a long issue thread, and I'm not quite sure what the status is right now, as a non-expert in CPython's build system 😄 I don't want to open a bug report at setup-python if it will be fixed anyway when beta2 comes out!

@erlend-aasland
Copy link

3.13.0b2 build system will fall back to the CPython vendored (but deprecated) libmpdecimal library, so unlike 3.13.0b1, 3.13.0b2 should have the _decimal C extension.

See also:

@AlexWaygood
Copy link
Member

AlexWaygood commented May 30, 2024

Thanks so much @erlend-aasland! @aminalaee, for the Linux-only stubtest allowlist entries, let's just do what I suggested in #12061 (comment) for now, in that case, since the allowlist entries will all go away naturally when we start using beta2 in CI :-)

@aminalaee aminalaee changed the title decimal: Python 3.13 Update Python 3.13 linux allowlist May 30, 2024
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood marked this pull request as ready for review May 30, 2024 11:43
@AlexWaygood AlexWaygood changed the title Update Python 3.13 linux allowlist py313: mark Linux-only decimal allowlist entries as unfixable for now May 30, 2024
@AlexWaygood AlexWaygood merged commit b780ac0 into python:main May 30, 2024
63 checks passed
@aminalaee aminalaee deleted the decimal-python3.13 branch May 30, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants