-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py313: mark Linux-only decimal allowlist entries as unfixable for now #12061
Conversation
68b050f
to
a72a2ba
Compare
This comment has been minimized.
This comment has been minimized.
1fb52b8
to
5c1a69f
Compare
369ade3
to
124f709
Compare
I think the parameter names changing only on Linux indicates that the |
I suggest that instead of trying to "fix" the Linux-only allowlist entries here, we move them to a separate section of the allowlist with a comment explaining why we shouldn't try to fix them at this point in time. |
This comment has been minimized.
This comment has been minimized.
Yeah I think that makes sense, I initially started this PR to double-check what I'm seeing is right. I didn't want to start another discussion in the CPython repo (yet) 😅 |
It definitely seems like the @erlend-aasland, would you be able to clarify that at all? python/cpython#115119 is a long issue thread, and I'm not quite sure what the status is right now, as a non-expert in CPython's build system 😄 I don't want to open a bug report at |
3.13.0b2 build system will fall back to the CPython vendored (but deprecated) libmpdecimal library, so unlike 3.13.0b1, 3.13.0b2 should have the See also: |
Thanks so much @erlend-aasland! @aminalaee, for the Linux-only stubtest allowlist entries, let's just do what I suggested in #12061 (comment) for now, in that case, since the allowlist entries will all go away naturally when we start using beta2 in CI :-) |
This reverts commit 124f709.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Just to test with the pipeline