Remove symlinks! #2132
Merged
Remove symlinks! #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
requested changes
May 15, 2018
| raise ValueError('File {f1} does not match file {f2}. Please copy it to {f2}'.format(f1=file1, f2=file2)) | ||
|
|
||
| if __name__ == '__main__': | ||
| main() |
There was a problem hiding this comment.
Missing a newline at the end.
tests/check_consistent.py
Outdated
| for file1, file2 in consistent_files: | ||
| f1 = os.path.join(os.getcwd(), file1) | ||
| f2 = os.path.join(os.getcwd(), file2) | ||
| if os.path.islink(f1): |
There was a problem hiding this comment.
This check should look at all files in typeshed, not just the hardcoded list of identical files.
| @@ -0,0 +1,29 @@ | |||
| import os | |||
There was a problem hiding this comment.
Can you add documentation here that says that we can't use symlinks for technical reasons, so we use this as a way to make sure certain groups of files stay identical?
tests/check_consistent.py
Outdated
| import os | ||
| import filecmp | ||
|
|
||
| consistent_files = [ |
There was a problem hiding this comment.
Wouldn't this make more sense as a list of sets, where every member of the set should be identical?
JelleZijlstra
approved these changes
May 15, 2018
gwk
pushed a commit
to gwk/typeshed
that referenced
this pull request
May 29, 2018
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes symlinks from typeshed, so I can finally get mypy to run cleanly on Windows.
Fixes #1175