-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.14] Address invalid inputs of TypeAliasType #477
Merged
JelleZijlstra
merged 22 commits into
python:main
from
Daraan:TypeAliasType/invalid_param_spec
Oct 25, 2024
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
507088c
type_params must be a tuple
Daraan c00494a
no non default value after default value
Daraan 4e2f041
Consider Type Error from python/cpython/pull/124795
Daraan b2412b0
Adjusted error messages to match cpython
Daraan 54a67ab
updated changelog
Daraan 64e4007
Removed invalid tests and left comment
Daraan dccb363
Slight modification of tests
Daraan 4edee59
fix indent
Daraan c928b20
Corrected 3.12.8 requirement
Daraan 9ad28aa
Merge 'main' into TypeAliasType/invalid_param_spec
Daraan 4b9a04c
Updated barrier to skip 3.12-3.13
Daraan 6ba3f5e
Merge branch 'main' into TypeAliasType/invalid_param_spec
JelleZijlstra e729c1f
Split compatibility checks into more methods
Daraan 83bbb98
Merge remote-tracking branch 'upstream/main' into TypeAliasType/inval…
Daraan ae88d98
Merge remote-tracking branch 'origin/TypeAliasType/invalid_param_spec…
Daraan 6bc5c46
Merge remote-tracking branch 'upstream/main' into TypeAliasType/inval…
Daraan 94b8c86
Draft for 3.12, 3.13 backport
Daraan 46ab3ac
Use TypeAliasType backport for <3.14
Daraan b38852e
fix typo and style
Daraan 1ef3e00
Unpack should not pass as a TypeVar
Daraan cdf7fec
Clarified statement about Unpack for < 3.12
Daraan c14567d
Updated unpack comment in main code
Daraan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What "some cases" exactly? Ideally this should be accepted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the comment for more clarity. As
isinstance(Unpack[Ts], TypeVar) is True
in Python < 3.12Unpack
would not raise here without the additional check and would be accepted as a type parameter.