Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for get_coreclr exception on Windows 32 bit #15

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Fix for get_coreclr exception on Windows 32 bit #15

merged 1 commit into from
Nov 10, 2021

Conversation

DareDevilDenis
Copy link
Contributor

Fix for issue #14

@dnfadmin
Copy link

dnfadmin commented Nov 2, 2021 •
edited
Loading

CLA assistant check
All CLA requirements met.

@DareDevilDenis DareDevilDenis mentioned this pull request Nov 2, 2021
Closed
@DareDevilDenis
Copy link
Contributor Author

I tested this change on:

  • 32 bit Windows: C:\Program Files
  • 64 bit Windows, 32 bit Python: C:\Program Files (x86)
  • 64 bit Windows, 64 bit Python

@filmor
Copy link
Member

filmor commented Nov 10, 2021

I believe you, and I still can't remember what kind of problem this code was supposed to fix :)

@filmor filmor merged commit c8ca462 into pythonnet:master Nov 10, 2021
@DareDevilDenis DareDevilDenis deleted the issue_14_fix_32_bit_windows branch November 12, 2021 13:52
@filmor filmor mentioned this pull request Dec 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DareDevilDenis @dnfadmin @filmor