Add --pooling in TBE nbit_cpu benchmark #2200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 7, 2023 16:09
Summary: Instead of using the ref implementation for sequence embedding on CPU, this diff directs TBE to invoke the AVX implementation of pooled TBE by forcing pooling factors of 1 (i.e., passing `at::arange(index_size + 1)` as offfsets). The performance gained from using the AVX implementation offsets the overhead incurs in creating the new offsets. Reviewed By: jspark1105, YazhiGao Differential Revision: D51918878
Summary: As title Differential Revision: D51963691
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D51963691 |
|
This pull request has been merged in 8724d89. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As title
Differential Revision: D51963691