Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the cache fetch for forward split, pt. 2 #2217

Closed
wants to merge 1 commit into from

Conversation

q10
Copy link
Contributor

@q10 q10 commented Dec 14, 2023

Summary: This follows up the work on D51865590 by plumbing the uvm_cache_stats argument passing up to the Python API level. local_uvm_cache_stats is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step.

Differential Revision: D51995949

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit f2d1f75
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/659dd4db61c74400081b72d3
😎 Deploy Preview https://deploy-preview-2217--pytorch-fbgemm-docs.netlify.app/_modules/fbgemm_gpu/split_table_batched_embeddings_ops_training
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51995949

@q10 q10 force-pushed the export-D51995949 branch from 8476bb5 to 08edaa0 Compare December 18, 2023 20:07
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 18, 2023
Summary:

This follows up the work on D51865590 by plumbing the `uvm_cache_stats` argument passing up to the Python API level.  `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step.

Differential Revision: D51995949
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51995949

q10 added a commit to q10/FBGEMM that referenced this pull request Dec 18, 2023
Summary:

This follows up the work on D51865590 by plumbing the `uvm_cache_stats` argument passing up to the Python API level.  `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step.

Differential Revision: D51995949
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51995949

q10 added a commit to q10/FBGEMM that referenced this pull request Dec 18, 2023
Summary:

This follows up the work on D51865590 by plumbing the `uvm_cache_stats` argument passing up to the Python API level.  `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step.

Differential Revision: D51995949
@q10 q10 force-pushed the export-D51995949 branch from 08edaa0 to 93e55e6 Compare December 18, 2023 20:10
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51995949

@q10 q10 force-pushed the export-D51995949 branch from 93e55e6 to 1993310 Compare December 19, 2023 19:08
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 19, 2023
Summary:

This follows up the work on D51865590 by plumbing the `uvm_cache_stats` argument passing up to the Python API level.  `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step.

Differential Revision: D51995949
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51995949

q10 added a commit to q10/FBGEMM that referenced this pull request Dec 19, 2023
Summary:

This follows up the work on D51865590 by plumbing the `uvm_cache_stats` argument passing up to the Python API level.  `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step.

Differential Revision: D51995949
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51995949

q10 added a commit to q10/FBGEMM that referenced this pull request Dec 19, 2023
Summary:

This follows up the work on D51865590 by plumbing the `uvm_cache_stats` argument passing up to the Python API level.  `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step.

Differential Revision: D51995949
@q10 q10 force-pushed the export-D51995949 branch from 1993310 to 333dc93 Compare December 27, 2023 09:09
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 27, 2023
Summary:

This follows up the work on D51865590 by plumbing the `uvm_cache_stats` argument passing up to the Python API level.  `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step.

Differential Revision: D51995949
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51995949

q10 added a commit to q10/FBGEMM that referenced this pull request Dec 27, 2023
Summary:

This follows up the work on D51865590 by plumbing the `uvm_cache_stats` argument passing up to the Python API level.  `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step.

Differential Revision: D51995949
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 27, 2023
Summary:

This follows up the work on D51865590 by plumbing the `uvm_cache_stats` argument passing up to the Python API level.  `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step.

Differential Revision: D51995949
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51995949

@q10 q10 force-pushed the export-D51995949 branch from 333dc93 to aab29fb Compare January 4, 2024 18:59
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 4, 2024
Summary:

This follows up the work on D51865590 by plumbing the `uvm_cache_stats` argument passing up to the Python API level.  `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step.

Reviewed By: sryap

Differential Revision: D51995949
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51995949

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 4, 2024
Summary:

This follows up the work on D51865590 by plumbing the `uvm_cache_stats` argument passing up to the Python API level.  `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step.

Reviewed By: sryap

Differential Revision: D51995949
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 4, 2024
Summary:

This follows up the work on D51865590 by plumbing the `uvm_cache_stats` argument passing up to the Python API level.  `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step.

Reviewed By: sryap

Differential Revision: D51995949
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51995949

Summary:

This follows up the work on D51865590 by plumbing the `uvm_cache_stats` argument passing up to the Python API level.  `local_uvm_cache_stats` is now zeroed out before the prefetch step as opposed to after, to allow for the data to be passed into the forward step.

Reviewed By: sryap

Differential Revision: D51995949
@q10 q10 force-pushed the export-D51995949 branch from aab29fb to f2d1f75 Compare January 9, 2024 23:20
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51995949

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51995949

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 86bf95d.

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by 7cee6e3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants