Always load custom op registrations #3265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D64770837 |
|
This pull request was exported from Phabricator. Differential Revision: D64770837 |
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Oct 22, 2024
Summary: Pull Request resolved: pytorch#3265 X-link: facebookresearch/FBGEMM#366 Since some custom operators now register shape functions in python, we can just directly import those registrations rather than hide them behind the OSS vs fbcode flag. This should fix a few CI issues introduced by recently added tests. Differential Revision: D64770837
jwfromm
force-pushed
the
export-D64770837
branch
from
414468b to
2bebfa7
Compare
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Oct 22, 2024
Summary: X-link: facebookresearch/FBGEMM#366 Since some custom operators now register shape functions in python, we can just directly import those registrations rather than hide them behind the OSS vs fbcode flag. This should fix a few CI issues introduced by recently added tests. Reviewed By: spcyppt Differential Revision: D64770837
jwfromm
force-pushed
the
export-D64770837
branch
from
2bebfa7 to
323afb3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64770837 |
jwfromm
force-pushed
the
export-D64770837
branch
from
323afb3 to
a4109a3
Compare
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Oct 22, 2024
Summary: X-link: facebookresearch/FBGEMM#366 Since some custom operators now register shape functions in python, we can just directly import those registrations rather than hide them behind the OSS vs fbcode flag. This should fix a few CI issues introduced by recently added tests. Reviewed By: spcyppt Differential Revision: D64770837
|
This pull request was exported from Phabricator. Differential Revision: D64770837 |
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Oct 22, 2024
Summary: X-link: facebookresearch/FBGEMM#366 Since some custom operators now register shape functions in python, we can clean up the initialization of the fbgemm gen_ai module to use the new operator files. This diff does that refactor, adds a helper function to load libraries in fbcode or oss, and adds a few additional operator files for other custom ops. Next, we should do full shape registration for those other custom operator libraries. Reviewed By: spcyppt Differential Revision: D64770837
jwfromm
force-pushed
the
export-D64770837
branch
from
a4109a3 to
55c3e5e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64770837 |
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Oct 22, 2024
Summary: X-link: facebookresearch/FBGEMM#366 Since some custom operators now register shape functions in python, we can clean up the initialization of the fbgemm gen_ai module to use the new operator files. This diff does that refactor, adds a helper function to load libraries in fbcode or oss, and adds a few additional operator files for other custom ops. Next, we should do full shape registration for those other custom operator libraries. Reviewed By: spcyppt Differential Revision: D64770837
jwfromm
force-pushed
the
export-D64770837
branch
from
55c3e5e to
af9beee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64770837 |
jwfromm
pushed a commit
to jwfromm/FBGEMM
that referenced
this pull request
Oct 22, 2024
Summary: X-link: facebookresearch/FBGEMM#366 Since some custom operators now register shape functions in python, we can clean up the initialization of the fbgemm gen_ai module to use the new operator files. This diff does that refactor, adds a helper function to load libraries in fbcode or oss, and adds a few additional operator files for other custom ops. Next, we should do full shape registration for those other custom operator libraries. Reviewed By: spcyppt Differential Revision: D64770837
jwfromm
force-pushed
the
export-D64770837
branch
from
af9beee to
b7dbd8a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64770837 |
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Oct 23, 2024
Summary: X-link: facebookresearch/FBGEMM#366 Since some custom operators now register shape functions in python, we can clean up the initialization of the fbgemm gen_ai module to use the new operator files. This diff does that refactor, adds a helper function to load libraries in fbcode or oss, and adds a few additional operator files for other custom ops. Next, we should do full shape registration for those other custom operator libraries. Reviewed By: spcyppt Differential Revision: D64770837
jwfromm
force-pushed
the
export-D64770837
branch
from
b7dbd8a to
b4e7583
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64770837 |
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Oct 23, 2024
Summary: X-link: facebookresearch/FBGEMM#366 Since some custom operators now register shape functions in python, we can clean up the initialization of the fbgemm gen_ai module to use the new operator files. This diff does that refactor, adds a helper function to load libraries in fbcode or oss, and adds a few additional operator files for other custom ops. Next, we should do full shape registration for those other custom operator libraries. Reviewed By: spcyppt Differential Revision: D64770837
jwfromm
force-pushed
the
export-D64770837
branch
from
b4e7583 to
a69ff66
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64770837 |
Summary: X-link: facebookresearch/FBGEMM#366 Since some custom operators now register shape functions in python, we can clean up the initialization of the fbgemm gen_ai module to use the new operator files. This diff does that refactor, adds a helper function to load libraries in fbcode or oss, and adds a few additional operator files for other custom ops. Next, we should do full shape registration for those other custom operator libraries. Reviewed By: jianyuh, spcyppt Differential Revision: D64770837
jwfromm
force-pushed
the
export-D64770837
branch
from
a69ff66 to
62d74c4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64770837 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/366
Since some custom operators now register shape functions in python, we can just directly import those registrations rather than hide them behind the OSS vs fbcode flag. This should fix a few CI issues introduced by recently added tests.
Differential Revision: D64770837