Store the prefetching results in a queue in SSD prefetcher, retrieve later in .forward() method #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: X-link: facebookresearch/FBGEMM#407 Add the unified prefetching API and a unit test for it to support SSD or parameter server offloading in CPU TBE. Design doc: https://docs.google.com/document/d/10gvSl00wjFnCZ6trO2o1L5jqYG6pOHBFyqObrDDVklc/edit?usp=sharing Differential Revision: D64705318
Summary: X-link: facebookresearch/FBGEMM#408 Add a method `register_ssd_prefetcher` in the inference TBE module to allow converting the module to SSD mode after initialization. Also extended the unit test to test the case of registering prefetcher at/after init and adding SSD placement list during/after init. Differential Revision: D65371577
…later in .forward() method Summary: X-link: facebookresearch/FBGEMM#409 Change the design of the SSD prefetcher interface such that when prefetching, store results in a queue of the SSD prefetcher. When the TBE module's `.forward()` method is called, it uses the prefetcher's `.get()` method to pop the prefetched result. Differential Revision: D65372062
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D65372062 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/409
Change the design of the SSD prefetcher interface such that when prefetching, store results in a queue of the SSD prefetcher. When the TBE module's
.forward()method is called, it uses the prefetcher's.get()method to pop the prefetched result.Differential Revision: D65372062