Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for int32_t indices in TBE training (2/N) #3326

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support for int32_t indices in TBE training (2/N) #3326

wants to merge 2 commits into from

Conversation

q10
Copy link
Contributor

@q10 q10 commented Nov 5, 2024

Summary: - Add index_t support to TBE training backward kernels

Differential Revision: D65464554

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65464554

@netlify Netlify
Copy link

netlify bot commented Nov 5, 2024 •
edited
Loading

✅ Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit c07b447
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/67352d079cb0650008d27eaf
😎 Deploy Preview https://deploy-preview-3326--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@q10 q10 force-pushed the export-D65464554 branch from 2c26f6f to 66afb9b Compare November 7, 2024 22:35
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65464554

q10 added a commit to q10/FBGEMM that referenced this pull request Nov 7, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2/N) (pytorch#3326)
811fb8d 
Summary:

X-link: facebookresearch/FBGEMM#420

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65464554
@q10 q10 force-pushed the export-D65464554 branch from 66afb9b to 811fb8d Compare November 7, 2024 23:22
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65464554

q10 added a commit to q10/FBGEMM that referenced this pull request Nov 7, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2/N) (pytorch#3326)
19c9427 
Summary:

X-link: facebookresearch/FBGEMM#420

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65464554
@q10 q10 force-pushed the export-D65464554 branch from 811fb8d to 19c9427 Compare November 7, 2024 23:59
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65464554

@q10 q10 force-pushed the export-D65464554 branch from 19c9427 to f13c09f Compare November 13, 2024 05:13
q10 added a commit to q10/FBGEMM that referenced this pull request Nov 13, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2/N) (pytorch#3326)
f13c09f 
Summary:

X-link: facebookresearch/FBGEMM#420

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65464554
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65464554

q10 added a commit to q10/FBGEMM that referenced this pull request Nov 13, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2/N) (pytorch#3326)
3d5eee1 
Summary:

X-link: facebookresearch/FBGEMM#420

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65464554
@q10 q10 force-pushed the export-D65464554 branch from f13c09f to 3d5eee1 Compare November 13, 2024 05:15
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65464554

q10 added a commit to q10/FBGEMM that referenced this pull request Nov 13, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2/N) (pytorch#3326)
6012a34 
Summary:

X-link: facebookresearch/FBGEMM#420

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65464554
@q10 q10 force-pushed the export-D65464554 branch from 3d5eee1 to 6012a34 Compare November 13, 2024 06:02
q10 added a commit to q10/FBGEMM that referenced this pull request Nov 13, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2/N) (pytorch#3326)
c007dbd 
Summary:

X-link: facebookresearch/FBGEMM#420

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65464554
@q10 q10 force-pushed the export-D65464554 branch from 6012a34 to c007dbd Compare November 13, 2024 06:03
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65464554

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65464554

q10 added a commit to q10/FBGEMM that referenced this pull request Nov 13, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2/N) (pytorch#3326)
193ff6e 
Summary:

X-link: facebookresearch/FBGEMM#420

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65464554
@q10 q10 force-pushed the export-D65464554 branch from c007dbd to 193ff6e Compare November 13, 2024 06:10
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65464554

@q10 q10 force-pushed the export-D65464554 branch from 193ff6e to e72093e Compare November 13, 2024 19:00
q10 added a commit to q10/FBGEMM that referenced this pull request Nov 13, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2/N) (pytorch#3326)
e72093e 
Summary:

X-link: facebookresearch/FBGEMM#420

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65464554
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65464554

q10 added a commit to q10/FBGEMM that referenced this pull request Nov 13, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2/N) (pytorch#3326)
dd61a7d 
Summary:

X-link: facebookresearch/FBGEMM#420

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65464554
@q10 q10 force-pushed the export-D65464554 branch from e72093e to dd61a7d Compare November 13, 2024 19:33
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65464554

@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2/N) (pytorch#3326)
ba352e7 
Summary:

X-link: facebookresearch/FBGEMM#420

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65464554
@q10 q10 force-pushed the export-D65464554 branch from dd61a7d to ba352e7 Compare November 13, 2024 19:40
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65464554

@q10 q10 force-pushed the export-D65464554 branch from 1a85f82 to c07b447 Compare November 13, 2024 22:49
@facebook-github-bot
Copy link
Contributor

Hi @q10!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@q10 @facebook-github-bot