Fix calling numel on symbolic shapes issue
#3621
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
`indices` could be symbolic shapes, calling `numel` on symbolic shapes will trigger a compilation issue as below: {F1974666689}
To fix the issue, we change `numel` to `sym_numel` in this diff to be compatible with symbolic shapes
Differential Revision: D68675691
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D68675691 |
|
This pull request was exported from Phabricator. Differential Revision: D68675691 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D68675691 |
|
This pull request has been merged in f258326. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
indicescould be symbolic shapes, callingnumelon symbolic shapes will trigger a compilation issue as below: {F1974666689}To fix the issue, we change
numeltosym_numelin this diff to be compatible with symbolic shapesDifferential Revision: D68675691