k_norm in rope for fp8 kv cache #3633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D68815109 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Aya-ZIbra
force-pushed
the
export-D68815109
branch
from
33429b1 to
611edca
Compare
Aya-ZIbra
pushed a commit
to Aya-ZIbra/FBGEMM
that referenced
this pull request
Feb 3, 2025
Summary: X-link: facebookresearch/FBGEMM#709 Zero init of dequantized kv in prefill (D68574038), prefill FA3: GQA decode (USE_MQA_ATTN=1): Evaluation results on task nq.0_shot: em: 0.146814 | f1: 0.282832 Triton Split-k: Evaluation results on task nq.0_shot: em: 0.147368 | f1: 0.284228 BF16, prefill FA3 : Evaluation results on task nq.0_shot: em: 0.148753 | f1: 0.285131 Reviewed By: jianyuh Differential Revision: D68815109
|
This pull request was exported from Phabricator. Differential Revision: D68815109 |
Aya-ZIbra
pushed a commit
to Aya-ZIbra/FBGEMM
that referenced
this pull request
Feb 3, 2025
Summary: X-link: facebookresearch/FBGEMM#709 Zero init of dequantized kv in prefill (D68574038), prefill FA3: GQA decode (USE_MQA_ATTN=1): Evaluation results on task nq.0_shot: em: 0.146814 | f1: 0.282832 Triton Split-k: Evaluation results on task nq.0_shot: em: 0.147368 | f1: 0.284228 BF16, prefill FA3 : Evaluation results on task nq.0_shot: em: 0.148753 | f1: 0.285131 Reviewed By: jianyuh Differential Revision: D68815109
Aya-ZIbra
force-pushed
the
export-D68815109
branch
from
611edca to
7a5fd5e
Compare
Summary: X-link: facebookresearch/FBGEMM#709 Zero init of dequantized kv in prefill (D68574038), prefill FA3: GQA decode (USE_MQA_ATTN=1): Evaluation results on task nq.0_shot: em: 0.146814 | f1: 0.282832 Triton Split-k: Evaluation results on task nq.0_shot: em: 0.147368 | f1: 0.284228 BF16, prefill FA3 : Evaluation results on task nq.0_shot: em: 0.148753 | f1: 0.285131 Reviewed By: jianyuh Differential Revision: D68815109
|
This pull request was exported from Phabricator. Differential Revision: D68815109 |
Aya-ZIbra
force-pushed
the
export-D68815109
branch
from
7a5fd5e to
3ba9ca8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68815109 |
|
This pull request has been merged in 6b5568a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Zero init of dequantized kv in prefill (D68574038), prefill FA3:
GQA decode (USE_MQA_ATTN=1): Evaluation results on task nq.0_shot: em: 0.146814 | f1: 0.282832
Triton Split-k: Evaluation results on task nq.0_shot: em: 0.147368 | f1: 0.284228
BF16, prefill FA3 :
Evaluation results on task nq.0_shot: em: 0.148753 | f1: 0.285131
Differential Revision: D68815109