Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark intel xpu #1259

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sunjiweiswift
Copy link

@sunjiweiswift sunjiweiswift commented Nov 11, 2024

Added llama for Intel support. The command is still sh benchmark.sh

Copy link

pytorch-bot bot commented Nov 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1259

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link

Hi @sunjiweiswift!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@sunjiweiswift sunjiweiswift force-pushed the benchmark_intel_xpu branch 5 times, most recently from f125ac2 to d769d90 Compare November 11, 2024 05:44
@jerryzh168
Copy link
Contributor

can you add some test command in summary to show how to run benchmarks for xpu

@jerryzh168 jerryzh168 added the topic: for developers Use this tag if this PR is mainly developer facing label Nov 12, 2024
@sunjiweiswift sunjiweiswift force-pushed the benchmark_intel_xpu branch 2 times, most recently from 5fb782a to 657ff7e Compare November 14, 2024 02:20
@sunjiweiswift
Copy link
Author

can you add some test command in summary to show how to run benchmarks for xpu

I modified the default_device variable ("default_device = 'cuda' if torch.cuda.is_available() else 'xpu' if torch.xpu.is_available() else 'cpu'") so it will be set to cuda on nvdia gpu and xpu on intel gpu. So I still use the “sh benchmark.sh” command .

@jerryzh168
Copy link
Contributor

@sunjiweiswift are you able to publish some benchmarking results as well? if so please add a new entry similar to https://github.com/pytorch/ao/tree/main/torchao/quantization#uintx-quantization with title "xpu backend"

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 15, 2024
@sunjiweiswift
Copy link
Author

sunjiweiswift commented Nov 18, 2024

@sunjiweiswift are you able to publish some benchmarking results as well? if so please add a new entry similar to https://github.com/pytorch/ao/tree/main/torchao/quantization#uintx-quantization with title "xpu backend"

Currently these quantizations are not fully supported. I updated the benchmark data of bf16 int8dq int8wo, and wikitext-perplexity has not been tested yet(I encountered a problem of insufficient memory on Intel GPU), and will be updated in subsequent commits
https://github.com/pytorch/ao/pull/1259/files#diff-c15f5d9d386c1899418529df1c6d7622f5f9dd151f193dbca841e40078b6c8bd

@jerryzh168
Copy link
Contributor

please rebase to resolve conflict before landing

@sunjiweiswift sunjiweiswift force-pushed the benchmark_intel_xpu branch 3 times, most recently from 6583b35 to 83ddbe3 Compare November 25, 2024 08:07
@sunjiweiswift
Copy link
Author

please rebase to resolve conflict before landing

The conflict has been resolved. Please complete the merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: for developers Use this tag if this PR is mainly developer facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants