Extend support for x_only = True extra metrics through canonical name retrieval #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… retrieval Summary: Index into the canonical name for a metric function, where function names are defined as tuples in the form `(canonical function name, customized function name)`. This diff extends support for extra metrics that are the same across all benchmark implementations, identified by the parameter `x_only = True`. Reviewed By: xuzhao9 Differential Revision: D58552578
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
|
This pull request was exported from Phabricator. Differential Revision: D58552578 |
|
This pull request has been merged in 86904ca. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Index into the canonical name for a metric function, where function names are defined as tuples in the form
(canonical function name, customized function name). This diff extends support for extra metrics that are the same across all benchmark implementations, identified by the parameterx_only = True.Reviewed By: xuzhao9
Differential Revision: D58552578