Skip to content

Commit

Permalink
Don't deactivate/remove conda on linux after validation (#1814)
Browse files Browse the repository at this point in the history
* Don't deactivate/remove conda on linux

* test
  • Loading branch information
atalman authored May 7, 2024
1 parent 2c67925 commit 615571c
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions .github/scripts/validate_binaries.sh
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ else
${PWD}/check_binary.sh
fi

# We are only interested in CUDA tests and Python 3.8-3.11. Not all requirement libraries are available for 3.12 yet.
if [[ ${INCLUDE_TEST_OPS:-} == 'true' && ${MATRIX_GPU_ARCH_TYPE} == 'cuda' && ${MATRIX_PYTHON_VERSION} != "3.12" ]]; then
source ./.github/scripts/validate_test_ops.sh
fi

if [[ ${TARGET_OS} == 'windows' ]]; then
python ./test/smoke_test/smoke_test.py ${TEST_SUFFIX}
else
Expand All @@ -64,13 +69,8 @@ else
export PATH=${OLD_PATH}
fi

# We are only interested in CUDA tests and Python 3.8-3.11. Not all requirement libraries are available for 3.12 yet.
if [[ ${INCLUDE_TEST_OPS:-} == 'true' && ${MATRIX_GPU_ARCH_TYPE} == 'cuda' && ${MATRIX_PYTHON_VERSION} != "3.12" ]]; then
source ./.github/scripts/validate_test_ops.sh
fi

# TODO: remove if statement currently this step is timing out on linx-aarch64
if [[ ${TARGET_OS} != 'linux-aarch64' ]]; then
# this is optional step
if [[ ${TARGET_OS} != linux* ]]; then
conda deactivate
conda env remove -n ${ENV_NAME}
fi
Expand Down

0 comments on commit 615571c

Please sign in to comment.